Skip to content

Avatar autogeneration fixed #13233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

Avatar autogeneration fixed #13233

merged 1 commit into from
Oct 23, 2020

Conversation

@pboguslawski
Copy link
Contributor

@pboguslawski pboguslawski commented Oct 21, 2020

This mod fixes problem with initial avatar autogeneration and
avatar autogneration after deleting previous avatar.

Related: #13159
Fixes: 80a6b0f
Author-Change-Id: IB#1105243

@pboguslawski
Avatar autogeneration fixed
e2252a6 
This mod fixes problem with initial avatar autogeneration and
avatar autogneration after deleting previous avatar.

Related: go-gitea#13159
Fixes: 80a6b0f
Author-Change-Id: IB#1105243
@pboguslawski pboguslawski mentioned this pull request Oct 21, 2020
Closed
@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #13233 into master will increase coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13233   +/-   ##
=======================================
  Coverage   42.21%   42.22%           
=======================================
  Files         683      683           
  Lines       75458    75458           
=======================================
+ Hits        31858    31859    +1     
+ Misses      38377    38375    -2     
- Partials     5223     5224    +1
Impacted Files Coverage Δ
models/user.go 54.24% <ø> (+0.06%) ⬆️
routers/user/setting/profile.go 40.22% <0.00%> (-0.71%) ⬇️
models/user_avatar.go 31.57% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
services/pull/patch.go 55.68% <0.00%> (+1.70%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9658610...e2252a6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 21, 2020
@lafriks lafriks added this to the 1.14.0 milestone Oct 21, 2020
zeripath
zeripath reviewed Oct 21, 2020
View reviewed changes
6543
6543 reviewed Oct 22, 2020
View reviewed changes
@pboguslawski
Copy link
Contributor Author

pboguslawski commented Oct 23, 2020

base.HashEmail(u.AvatarEmail) was taken from CreateUser; u.AvatarEmail seems to be protected against "":

gitea/models/user.go

Line 821 in e2252a6

u.AvatarEmail = u.Email

gitea/models/user.go

Line 190 in e2252a6

if len(u.AvatarEmail) == 0 {

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2020
@lafriks lafriks merged commit d2ad4de into go-gitea:master Oct 23, 2020
@lafriks
Copy link
Member

lafriks commented Oct 23, 2020

please send backport

@pboguslawski pboguslawski mentioned this pull request Oct 23, 2020
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Oct 23, 2020
@pboguslawski pboguslawski deleted the master-IB#1105243 branch October 30, 2020 21:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 left review comments

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pboguslawski @codecov-io @lafriks @zeripath @6543 @GiteaBot